Add ability to support registryOverride #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,7 +131,7 @@ type PodOptions struct { | |||
| // namespace used only for the purpose of running impersonated pods. This is to ensure | |||
| // proper protection for the service accounts created. | |||
| // 2. The pod must KUBECONFIG env var set to where you expect the kubeconfig to reside | |||
| func (s *PodImpersonation) CreatePod(ctx context.Context, user user.Info, pod *v1.Pod, podOptions *PodOptions) (*v1.Pod, error) { | |||
| func (s *PodImpersonation) CreatePod(ctx context.Context, user user.Info, pod *v1.Pod, podOptions *PodOptions, registryOverride string) (*v1.Pod, error) { | |||
There was a problem hiding this comment.
I think a better approach would be to just add ImageName as a field on PodOptions that if set it will use that instead of calling the func() string.
StrongMonkey
force-pushed
the
add-registry
branch
from
6e8fbc1 to
7ad1688
Compare
StrongMonkey
force-pushed
the
add-registry
branch
from
7ad1688 to
2309fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to support cluster-level private registry support. rancher/rancher#30735