Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip key generation if cache disabled #170

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

rmweir
Copy link
Contributor

@rmweir rmweir commented Mar 18, 2024

@rmweir rmweir marked this pull request as ready for review March 18, 2024 21:50
@rmweir rmweir requested a review from a team as a code owner March 21, 2024 16:35
@MbolotSuse MbolotSuse self-requested a review March 21, 2024 17:23
aruiz14 pushed a commit to aruiz14/steve that referenced this pull request Mar 26, 2024
aruiz14 added a commit to rancher/rancher that referenced this pull request Mar 26, 2024
Copy link
Contributor

@aruiz14 aruiz14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/stores/partition/store.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomleb tomleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seems like this area is already well tested too.

@tomleb
Copy link
Contributor

tomleb commented Apr 17, 2024

CI is failing because it's still using old Go < 1.22. Needs a rebase.

@rmweir
Copy link
Contributor Author

rmweir commented Apr 19, 2024

@tomleb ci is passing, ready for merge

@tomleb tomleb merged commit d42a5bc into rancher:master Apr 19, 2024
1 check passed
rmweir added a commit to rmweir/steve that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants