Attempting to fix flaky tests #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses: rancher/rancher#44873 |
|
Note: @tomleb suggested some improvements, putting this on hold until they are done. |
tomleb
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Some typos but otherwise looks good. Would be great to test the CI a couple of times to give a best effort verification on whether it fixes the issue or not.
You could for example create a new dummy PR with the same codechange but and give -count parameter to the go test command.
Some tests which relied on timeouts were a bit flaky in CI. This PR refactors a few of them to work on a more reliable method of receiving from a channel and raises the timeout of another test.
tomleb
approved these changes
Apr 3, 2024
JonCrowther
approved these changes
Apr 3, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests which relied on timeouts were a bit flaky in CI. This PR raises the timeouts, which seemed to help with the flakiness on local testing.