fix(accesscontrol): CacheKey could not be stable #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While understanding how this code works, we realized (actually it was @bigkevmcd, kudos to him) 2 problems:
According to the
copy
godoc:This makes the following code to produce an empty slice, since only the length is taken into account, not the capacity:
The
groups
variable is not actually used, since werange
overuser.GetGroups()
(the unused variable warning was probably masked by usingsort.Strings
).I have no evidence this could be currently causing any problems though. It depends on the underlying implementation of
GetGroups()
. For our use case, it does not really matter if the slice is actually sorted, the only requirement would be to be stable.Unit tests added in follow-up PR containing a small refactoring to make it easier to test:
#245