Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Group, Version, Kind in Update proxy_store.go #270

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Adding Group, Version, Kind in Update proxy_store.go #270

merged 9 commits into from
Sep 13, 2024

Conversation

gehrkefc
Copy link
Contributor

This is related to rancher/rancher issue: 42823

@gehrkefc gehrkefc requested a review from a team as a code owner August 30, 2024 22:22
@gehrkefc gehrkefc mentioned this pull request Aug 30, 2024
Closed
@gehrkefc gehrkefc changed the title Adding Group, Version, Kind in proxy_store.go Adding Group, Version, Kind in to Update proxy_store.go Aug 30, 2024
ericpromislow
ericpromislow requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't overwrite supplied values?

@gehrkefc
Copy link
Contributor Author

gehrkefc commented Sep 3, 2024

Probably don't overwrite supplied values?

Added a check based in our conversation. Should we consider a situation where the user provides only one of the values and we complete only the other one ? Can this generate any kind of inconsistency ?

ericpromislow
ericpromislow previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. I don't see an inconsistency if only one value is specified -- defaults and specified values work the same way elsewhere, like command-line options

@gehrkefc gehrkefc changed the title Adding Group, Version, Kind in to Update proxy_store.go Adding Group, Version, Kind in Update proxy_store.go Sep 6, 2024
tomleb
tomleb reviewed Sep 12, 2024
View reviewed changes
pkg/stores/proxy/proxy_store_test.go Outdated Show resolved Hide resolved
pkg/stores/proxy/proxy_store_test.go Outdated Show resolved Hide resolved
pkg/stores/sqlproxy/proxy_store_test.go Outdated Show resolved Hide resolved
pkg/stores/sqlproxy/proxy_store_test.go Outdated Show resolved Hide resolved
pkg/stores/proxy/proxy_store_test.go Show resolved Hide resolved
pkg/stores/sqlproxy/proxy_store_test.go Show resolved Hide resolved
tomleb
tomleb previously approved these changes Sep 12, 2024
View reviewed changes
ericpromislow
ericpromislow requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have lots of fmt.Errorf(STRING) but we shouldn't add more.

Everything else looks fine.

@gehrkefc gehrkefc requested a review from tomleb September 13, 2024 14:51
ericpromislow
ericpromislow approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gehrkefc gehrkefc merged commit 99e479b into main Sep 13, 2024
1 check passed
@gehrkefc gehrkefc mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MbolotSuse MbolotSuse MbolotSuse left review comments

@tomleb tomleb tomleb approved these changes

@ericpromislow ericpromislow ericpromislow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gehrkefc @ericpromislow @tomleb @MbolotSuse