Display error output from dynamiclistener.Server when in debug mode. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleb
reviewed
Sep 4, 2024
main.go
Outdated
| @@ -38,5 +39,5 @@ func run(_ *cli.Context) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return s.ListenAndServe(ctx, config.HTTPSListenPort, config.HTTPListenPort, nil) | |||
| return s.ListenAndServe(ctx, config.HTTPSListenPort, config.HTTPListenPort, &server.ListenOpts{DisplayServerLogs: debugconfig.Debug}) | |||
There was a problem hiding this comment.
Those logs should pretty much always be set. I shouldn't have to run with --debug to see panics imo. They are error logs.
There was a problem hiding this comment.
Then we should drop that DisplayServerLogs option and always turn on "logging" (remember that only error-level output comes out of this process)
There was a problem hiding this comment.
No, we still need the option to keep the old behavior for other projects (k3s, rke2). Steve, Rancher and webhook will turn it on by default (eg: DisplayServerLogs: true) but the other projects won't (or they might, but we don't decide this).
ericpromislow
force-pushed
the
46956-bump-dynamic-listener
branch
from
bc0a9b1 to
69906c5
Compare
MbolotSuse
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #46956 (v2.10)
This change let's the user of the Steve CLI decide whether to see panic output with
--debugon,or squelched otherwise.