Drop things from the queue when completed #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibuildthecloud Can you take a look at this? I can't request reviewers in this repo. |
|
Do you have more context on why the enqueueAfter change? |
|
To try again, if you want to just mark the object as done regardless I can do that. |
|
Ah, so the memory leak is that we don't ever call done? I don't think we want to reenque. I'd just always call done. |
ibuildthecloud
pushed a commit
to ibuildthecloud/steve
that referenced
this pull request
Apr 4, 2022
Add github action for Steve releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#26633
rancher/rancher#26577