-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inherited_cluster_roles attribute to global_role #1242
Add inherited_cluster_roles attribute to global_role #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small issues, and I think we also need to update the docs/resources/role_template.md
file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the outstanding question on versioning for the rancher bits, I think this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than rancher version bits as well. Not sure how we handle versioning in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echoing LGTM but not sure about the version bumps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmatseykanets Rancher version bump lgtm, on second thought I think it's the safest option to have TF reference the rancher/rancher commit where the backend for InheritedGlobalRoles
was merged in. Can't be 100% sure the provider supports the later commits yet. Good to merge
Issue:
rancher/rancher#42967
Problem
inheritedClusterRoles
is a new field in global roles. We should be able to set it using rancher terraform provider when creating/updating a global role resource.Solution
A new attribute
inherited_cluster_roles
was added to the global role.Testing
Check that
inherited_cluster_roles
attribute is correctly populated when a global role is created/updated.Engineering Testing
Manual Testing
Used a local build of the rancher terraform provider against a local k8s cluster v1.27.4+k3s1 running rancher v2.8 HEAD (c7af81ec9c55b) to create and update a global role with inherited cluster roles.
Automated Testing
Unit tests updated to cover the new attribute.
QA Testing Considerations
Regressions Considerations