Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default dynamic to false #1427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

default dynamic to false #1427

wants to merge 1 commit into from
+0 −1

Conversation

kinarashah
Copy link
Member

@kinarashah kinarashah commented Oct 17, 2024 •
edited
Loading

Issue:

#1426

Solution

I removed default truefor the dynamic field to align with the default API settings, which also has the added benefit of resolving the issue of duplicate entries being added.

Manual Testing

  • Set up an RKE2 cluster following the steps in the linked issue. Ran multiple updates on the cluster to confirm that no duplicate entries were added.
  • Changed the default PSACT from rancher-restricted to rancher-privileged and made sure it worked without causing the cluster to error out with the message secret xxxx-psact does not contain the expected content.

@kinarashah kinarashah marked this pull request as ready for review October 18, 2024 23:09
@kinarashah kinarashah requested review from jiaqiluo and a team October 18, 2024 23:10
@jiaqiluo jiaqiluo requested review from a team and matttrach October 18, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqiluo jiaqiluo jiaqiluo approved these changes

@matttrach matttrach Awaiting requested review from matttrach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinarashah @jiaqiluo