Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TFP RKE to RKE v1.4.6 to support 1.25 clusters #403

Closed
a-blender opened this issue Jun 13, 2023 · 4 comments
Closed

Update TFP RKE to RKE v1.4.6 to support 1.25 clusters #403

a-blender opened this issue Jun 13, 2023 · 4 comments

Comments

@a-blender
Copy link
Contributor

Update TFP rke provider to rke 1.4.5 so customers can provision 1.25 clusters. Release the TFP rke provider 1.4.2 with that new version (or with 1.4.6 if it's updated by then).

@a-blender
Copy link
Contributor Author

@sowmyav27 Author of the community PR that bumped RKE outlines his test steps here #397 (comment). You really only need to test

  • Provisioning a 1.25 cluster via TFP rke
  • Provisioning a 1.24 cluster via TFP rke, upgrading to 1.25 with a terraform apply

@a-blender a-blender added this to the 2023-Q2-v2.7x - Terraform milestone Jun 13, 2023
@a-blender a-blender added area/terraform enhancement New feature or request labels Jun 13, 2023
@a-blender a-blender changed the title Update TFP rke to rke v1.4.5 Update TFP RKE to RKE v1.4.5 to support 1.25 clusters Jun 13, 2023
@zube zube bot added the QA/S label Jun 14, 2023
@a-blender a-blender changed the title Update TFP RKE to RKE v1.4.5 to support 1.25 clusters Update TFP RKE to RKE v1.4.6 to support 1.25 clusters Jun 21, 2023
@a-blender
Copy link
Contributor Author

@kinarashah and I discussed this issue, and we will be waiting to release TFP RKE until RKE has been updated to 1.4.6 in the upcoming Rancher release.

@thaneunsoo
Copy link

Test Environment:

Rancher version: v2.7-head a6f74ea
Rancher cluster type: HA
Docker version: 20.10

Downstream cluster type:


Testing:

Tested the following cases:

  1. Provisioning a 1.25 cluster via TFP rke
  2. Provisioning a 1.24 cluster via TFP rke, upgrading to 1.25 with a terraform apply

Result
Provisioning a 1.25 cluster via TFP rke - Pass
Provisioning a 1.24 cluster via TFP rke, upgrading to 1.25 with a terraform apply - Pass

@zube zube bot closed this as completed Jul 6, 2023
@a-blender
Copy link
Contributor Author

@timirnich You testing this using a local Terraform binary with the latest updates on master, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants