Patch & re-assign rke_cluster_yaml post create
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Ouellet <mathieu.ouellet@energumen.io>
|
@mouellet , I'll have someone from my team review and merge if it looks good. Meanwhile, could you please modify the description and remove "fixes" word so GH doesn't automatically close the associated issue when this PR is merged? We close issues only after they have been validated by the QA. |
snasovich
approved these changes
Apr 1, 2022
|
Doesn't look like I have necessary permissions here (can't even clear my approval - approved just to check if my approval counts). Working on having this fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ref: #326
I found out that the
rke_cluster_yamlwas not updated when calling read after create while the RKE state was... So the read from the first run returns the value from before the execution but later reads from the actual RKE state.