Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Github Actions #458

Merged
merged 1 commit into from
May 22, 2024

Conversation

HarrisonWAffel
Copy link
Contributor

A successful release run can be seen here: https://github.com/HarrisonWAffel/terraform-provider-rke/actions/runs/9134279456/job/25119495718
The github release and artifacts can be seen here: https://github.com/HarrisonWAffel/terraform-provider-rke/releases/tag/v0.0.0

A successful pre-release run can be seen here: https://github.com/HarrisonWAffel/terraform-provider-rke/actions/runs/9134582382/job/25120404739
The github pre-release artifacts can be seen here: https://github.com/HarrisonWAffel/terraform-provider-rke/releases/tag/v0.0.0-rc2

I've tested the GPG signing using my personal GPG key, which confirms it is singed correctly

gpg --verify terraform-provider-rke_0.0.0_SHA256SUMS.sig terraform-provider-rke_0.0.0_SHA256SUMS
gpg: Signature made Fri May 17 21:16:06 2024 UTC
gpg:                using RSA key B1BB4CAE50A884D616C4DCF69A6B757E291A63DF
gpg: Good signature from "Harrison Affel <harrison.affel@suse.com>" [unknown]
Primary key fingerprint: B1BB 4CAE 50A8 84D6 16C4  DCF6 9A6B 757E 291A 63DF

Also, I've dropped the use of golint as it is no longer maintained and does not properly handle go modules, even when GO111MODULE=off is not set. We should consider adding a new linter into this project, but currently this PR focuses on making the minimal amount of changes needed to migrate to GHA.

@HarrisonWAffel HarrisonWAffel requested a review from a team May 17, 2024 22:04
@HarrisonWAffel HarrisonWAffel requested a review from a team May 20, 2024 17:18
@HarrisonWAffel HarrisonWAffel merged commit 22afb27 into rancher:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants