Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shell scripts more portable #51

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Make shell scripts more portable #51

merged 1 commit into from
Feb 14, 2019

Conversation

meangrape
Copy link
Contributor

Some non-Linux systems don't ship with the bash command in the /bin
directory -- in fact, some don't ship with bash at all.

Using /usr/bin/env to find the bash executable ensures that if there
is a bash executable on the PATH it will be used.

Some non-Linux systems don't ship with the `bash` command in the /bin
directory -- in fact, some don't ship with bash at all.

Using `/usr/bin/env` to find the bash executable ensures that if there
is a `bash` executable on the PATH it will be used.
Copy link
Contributor

@yamamoto-febc yamamoto-febc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:
Thank you!!

@yamamoto-febc yamamoto-febc merged commit 9449839 into rancher:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants