Fix where to create temporary files #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(from @mkozjak's comment, thank you @mkozjak!)
This PR fixes to where to create temporary files.
Motivation/Background
The expected behavior of creating temporary files is as follows:
cluster.yml
andkube_config_cluster.yml
is generated into the temporary directory.However, current provider doesn't work well.
This unexpected behavior is based on to bad calling to following RKE's function:
https://github.com/rancher/rke/blob/v0.1.15/pki/util.go#L278-L286
Function
pki.GetLocalKubeConfig
has two arguments.The function changes the behavior depending on whether there is a slash at the end of the second argument.
If args are (
cluster.yml
,/foo/bar/
), the function returns/foo/bar/kube_config_cluster.yml
.If args are (
cluster.yml
,/foo/bar
), the function returns/foo/kube_config_cluster.yml
.This is very confusing.
So I decided don't use second argument, always specify
""
.Acceptance test results: