Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPIProvider: secret is not assigned by default #787

Closed
Danil-Grigorev opened this issue Oct 18, 2024 · 0 comments · Fixed by #788
Closed

CAPIProvider: secret is not assigned by default #787

Danil-Grigorev opened this issue Oct 18, 2024 · 0 comments · Fixed by #788
Assignees
Labels
kind/bug Something isn't working

Comments

@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Oct 18, 2024

What steps did you take and what happened?

Create a minimal CAPIProvider template:

apiVersion: turtles-capi.cattle.io/v1alpha1
kind: CAPIProvider
metadata:
  name: azure
  namespace: capz-system
spec:
  type: infrastructure

What did you expect to happen?

Default set of FG to be set. None are set by default, due to generated secret not being referenced in the underlying InfrastructurProvider resource, created from the supplied template.

For each provider (at the time of issue creation) the default set consists of:

EXP_CLUSTER_RESOURCE_SET: true
CLUSTER_TOPOLOGY: true
EXP_MACHINE_POOL: true

Each value can be overridden with spec.features or spec.variables, but requiring these values to be always present is creating inconsistencies with e2e scenarios and real world cluster template examples. A user is not supposed to read test/e2e templates first, to create a provider and get a Cluster.

How to reproduce it?

Always

Rancher Turtles version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants