Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove requirement to specify CAPIProvider secret #788

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Oct 18, 2024

What this PR does / why we need it:
This change improves the process of CAPIProvider creation. Users don’t need to specify spec.configSecret at all times, in order to get default set of enabled features, such as ClusterClasses or MachinePools, + provider specific features.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #787

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev added the kind/bug Something isn't working label Oct 18, 2024
@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner October 18, 2024 12:59
@Danil-Grigorev Danil-Grigorev force-pushed the simplify-capiprovider-default branch from 74bd9ce to c5d9df2 Compare October 18, 2024 13:01
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@salasberryfin
Copy link
Contributor

salasberryfin commented Oct 21, 2024

Thanks @Danil-Grigorev. If using this "minimal" CAPIProvider yaml and, for example, wanting to enable Cluster Classes, is it not required to pass the CUSTER_TOPOLOGY environment variable to the provider? This question would apply to any other feature that used to be enabled via variables before this change.

@Danil-Grigorev
Copy link
Contributor Author

@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) October 22, 2024 13:59
@Danil-Grigorev Danil-Grigorev merged commit f4d8547 into rancher:main Oct 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPIProvider: secret is not assigned by default
3 participants