Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Run release workflow periodically #235

Merged

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Oct 26, 2023

What this PR does / why we need it:

Based on @Danil-Grigorev's work on refactoring the release process to make jobs reusable here, this PR adds a nightly workflow (frequency can be modified if nightly is considered too often) that validates these reusable workflows by following the release process and avoiding pushing images to the production registry and publishing helm charts.

The testing workflow is based on creating a fake tag t9.9.9-fake (this naming is used to avoid triggering the real release action and is similar to the approach used in upstream CAPI). The workflow then follows the build/sign/release process:

  • Build images.
  • Sign images.
  • Create provenance.
  • Build Helm chart.

The images are only pushed to GitHub Container Registry and Helm charts are created but not published.

When the action finishes, no matter the result, the testing tag is deleted so that it can be used in the next execution of the test.

If any of the steps fail to run, a notification will be sent to the Slack channel we use for nightly E2E testing alerts.

Which issue(s) this PR fixes:
Fixes #214

Special notes for your reviewer:

### This PR depends on #232.

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@salasberryfin salasberryfin added area/testing Indicates an issue related to test kind/chore labels Oct 26, 2023
@salasberryfin salasberryfin requested a review from a team as a code owner October 26, 2023 07:37
@salasberryfin salasberryfin changed the title Run release workflow periodically WIP: Run release workflow periodically Oct 26, 2023
@salasberryfin salasberryfin force-pushed the run-release-workflow-periodically branch 8 times, most recently from 94aba8e to d5f72d2 Compare October 26, 2023 08:10
@salasberryfin salasberryfin changed the title WIP: Run release workflow periodically 🌱 Run release workflow periodically Oct 26, 2023
@richardcase
Copy link
Contributor

This looks good. Will do final review after #232 has merged and this rebased.

@salasberryfin salasberryfin force-pushed the run-release-workflow-periodically branch 5 times, most recently from f516c19 to 1be331d Compare October 26, 2023 14:12
@salasberryfin
Copy link
Contributor Author

This is now updated to use the latest version of #232

@salasberryfin salasberryfin force-pushed the run-release-workflow-periodically branch 3 times, most recently from 492f6a5 to b85484f Compare October 30, 2023 10:38
@salasberryfin
Copy link
Contributor Author

Now aligned with #232 latest improvements.

@furkatgofurov7
Copy link
Contributor

This looks good. Will do final review after #232 has merged and this rebased.

+1

@richardcase
Copy link
Contributor

#232 has noe been merged. @salasberryfin - any chance you'd be able to rebase?

@salasberryfin salasberryfin force-pushed the run-release-workflow-periodically branch 2 times, most recently from bcf94dc to 2de8c32 Compare November 3, 2023 12:45
@salasberryfin salasberryfin requested a review from a team November 3, 2023 12:55
@salasberryfin salasberryfin force-pushed the run-release-workflow-periodically branch from 2de8c32 to 7308d3e Compare November 3, 2023 13:02
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@salasberryfin salasberryfin force-pushed the run-release-workflow-periodically branch from 7308d3e to c0cb4ad Compare November 15, 2023 09:08
@salasberryfin
Copy link
Contributor Author

Last update includes the multiarch job from #251.

Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as the improvements could be added later.

@richardcase richardcase merged commit 0a3a60b into rancher:main Nov 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Release] Run release workflow nightly (without pushing to prod)
4 participants