test: add rke2 cluster to e2e test cases #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
changed the title
salasberryfin
force-pushed
the
test-cover-carpke2-in-short-e2e
branch
3 times, most recently
from
364d6aa to
ba46450
Compare
salasberryfin
changed the title
salasberryfin
requested review from
a team,
yiannistri,
alexander-demicev,
Danil-Grigorev and
furkatgofurov7
and removed request for
a team
There was a problem hiding this comment.
Overall looks good thanks @salasberryfin, one question/suggestion inline:
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
test-cover-carpke2-in-short-e2e
branch
from
ba46450 to
4e6d591
Compare
Danil-Grigorev
approved these changes
Jun 10, 2024
furkatgofurov7
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provision RKE2 CAPI clusters in short e2e tests. This PR also updates the version of the Docker provider, as we need to use some of the fields that don't exist in the old provider version.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist: