Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add adr for v1 to v3 controller migration #573

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

salasberryfin
Copy link
Contributor

kind/documentation

What this PR does / why we need it:

This is a work-in-progress.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@salasberryfin salasberryfin added the kind/documentation Improvements or additions to documentation label Jun 12, 2024
@salasberryfin salasberryfin changed the title WIP: docs: add adr for v1 to v3 controller migration docs: add adr for v1 to v3 controller migration Jun 18, 2024
@salasberryfin salasberryfin marked this pull request as ready for review June 18, 2024 08:56
@salasberryfin salasberryfin requested a review from a team as a code owner June 18, 2024 08:56
@salasberryfin
Copy link
Contributor Author

Thanks @alexander-demicev @Danil-Grigorev. I added references to the original v3 controller ADR where relevant.

@salasberryfin
Copy link
Contributor Author

Added reference to automatic migration ADR and cluster-api.cattle.io/owned label. I think it is ready for a final review.

Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@Danil-Grigorev Danil-Grigorev disabled auto-merge June 28, 2024 09:41
@furkatgofurov7
Copy link
Contributor

Merging this as this is just a documentation PR and there is no point of running/waiting for E2E tests

@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) June 28, 2024 09:42
@Danil-Grigorev Danil-Grigorev disabled auto-merge June 28, 2024 09:44
@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) June 28, 2024 09:44
@Danil-Grigorev Danil-Grigorev disabled auto-merge June 28, 2024 09:45
@Danil-Grigorev Danil-Grigorev merged commit b37d451 into rancher:main Jun 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

4 participants