Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add fleet addon config with auto-import label setting #609

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

What this PR does / why we need it:
This change ensures that CAAPF is always installed/upgraded with existing FleetAddonConfig resource, which includes all required settings and label selectors for the turtles import expectations.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #605

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner July 22, 2024 08:10
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev force-pushed the fleet-auto-import-settings branch from 40b0c80 to f617eea Compare July 22, 2024 08:55
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@alexander-demicev alexander-demicev merged commit fab681d into rancher:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cluster API Addon Provider Fleet FleetAddonConfig resource to helm chart
3 participants