-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor E2E suite to make it more generic #637
Refactor E2E suite to make it more generic #637
Conversation
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
fae53ba
to
f11a7ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for PR, 2 comments inline:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great.
f11a7ad
to
0b30046
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
0b30046
to
cba272a
Compare
} | ||
} | ||
|
||
// PreRancherTurtlesInstallHook is a hook that can be used to perform actions before Rancher Turtles is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// PreRancherTurtlesInstallHook is a hook that can be used to perform actions before Rancher Turtles is installed. | |
// PreRancherTurtlesUpgradelHook is a hook that can be used to perform actions before Rancher Turtles is upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving the approval as it "needs to be dirty and quick" but leaving some suggestions.
@Danil-Grigorev @furkatgofurov7 I will address typos/naming comments in a follow-up PR |
What this PR does / why we need it:
This PR is a part of the E2E refactoring issue, it includes the following changes:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: