-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add option to skip rancher pre-requisites #705
🌱 Add option to skip rancher pre-requisites #705
Conversation
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Thanks for working on this @Danil-Grigorev - the change looks good to me, although it's now clear we could potentially use the existing Note for other reviewers the use-case behind #627 is we want to deploy Rancher and Rancher Turtles via the RKE2 helm controller - in this situation ordering of the helm installs cannot be controlled, so you end up reliant on retries, so we must ensure the turtles chart can either install, or fail and be uninstalled, in the case where Rancher is not yet installed. A related issue is in the pre-delete hook we assume the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Danil-Grigorev can we also update the turtles docs regarding this, since current docs have rancher listed as pre-requisite and has a dedicated chapter for installing it before Turtles? I believe this provides a fix for the specific use case edge team has, but I suggest we need to be super clear on what are the consequences if this option is enabled.
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
faf8d23
What this PR does / why we need it:
This change should allow to install turtles in development scenario without dependency on rancher, for the expense of added requirement to patch the
embedded-cluster-api
feature gate manually.This can be done by specifying
--set rancherTurtles.rancherInstalled=false
flag.Deletion will need to be performed according to https://turtles.docs.rancher.com/getting-started/uninstall_turtles
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #627
Special notes for your reviewer:
Checklist: