Build image streamline #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
added
the
kind/cleanup
|
e2e/ci tests are not running automatically, perhaps it needs force-push? Otherwise LGTM |
furkatgofurov7
added
the
area/build-and-release
|
Thanks @furkatgofurov7. Looks like it ran after you added an extra label. Something seems to be off with automatic workflow runs in PRs. |
yeah, I think it is after 5e40f98 |
furkatgofurov7
approved these changes
Oct 31, 2024
alexander-demicev
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove some unused variables from
Makefileand etcdrestore image build process.Which issue(s) this PR fixes:
Fixes #824
Special notes for your reviewer:
I simply moved
docker-buildup anddocker-build-etcdrestoredown, so Turtles appears before etcdrestore, and added a sub-section title, but Git got confused and reported all these changes. Essentially it should just be a switch in order.Checklist: