Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updatecli] Perform replacement of CAPIVersion in tests and e2e #840

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Nov 4, 2024

What this PR does / why we need it:

Based on observed failure during CI execution in #835.

We perform e2e tests and integration tests, which ensure that a new turtles release will update latest target for provider, and will perform upgrade if the latest is set on CAPIProvider.

Current updatecli PRs don’t modify these values, which leads to CI failures after any core provider version changes.

Testing is performed on Danil-Grigorev#5, which is created using make updatecli-apply

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Danil-Grigorev. There are other occurrences of core CAPI version that I'd suggest we also bump via updatecli:

Could we use this PR to cover these files too?

@Danil-Grigorev
Copy link
Contributor Author

I think location in turtles-dev is not required to have a specified version. It additionally poses issues while running etcd snapshot restore, more details in #843.

Updating go.mod locations creates an overlap with dependabot configuration. It additionally requires executing a chain of make generate updates in other packages, further increasing complexity of the automation and requiring added commits with changes to be included in the PR. Currently this functionality is implemented for dependabot PRs.

I think these changes are out of scope for this PR, but make sense to give a centralized configuration to update all occurrences of CAPIProvider versions and go.mod and other locations as a separate updatecli target, which will not be executed via github actions but rather will be available for local invocation.

@salasberryfin
Copy link
Contributor

Thanks @Danil-Grigorev. You are right, this PR's scope is well limited and we can take the discussion of what to do with other version bumps offline, as it may have other implications.

@salasberryfin salasberryfin merged commit 5cae01d into rancher:main Nov 8, 2024
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants