Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker build for e2e image #902

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

alexander-demicev
Copy link
Member

@alexander-demicev alexander-demicev commented Dec 3, 2024

What this PR does / why we need it:

Use docker build instead of buildx for e2e because buildx takes too much for a test image to build.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #893

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@alexander-demicev alexander-demicev added kind/bug Something isn't working area/testing Indicates an issue related to test labels Dec 3, 2024
@alexander-demicev alexander-demicev requested a review from a team as a code owner December 3, 2024 15:27
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release job seems to be using docker-build-and-push task so it won’t affect it. The downside - we will no longer test release building flow this way.

@alexander-demicev alexander-demicev merged commit c255ac9 into rancher:main Dec 4, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the e2efix branch December 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E image sometimes get stuck when building
3 participants