Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CAPI and CAPA #913

Closed
wants to merge 3 commits into from
Closed

Bump CAPI and CAPA #913

wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 10, 2024 •
edited
Loading

Bumps the dependencies group with 3 updates in the / directory: github.com/onsi/ginkgo/v2, github.com/onsi/gomega and golang.org/x/text.

Updates github.com/onsi/ginkgo/v2 from 2.21.0 to 2.22.0

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.22.0

2.22.0

Features

  • Add label to serial nodes [0fcaa08]

This allows serial tests to be filtered using the label-filter

Maintenance

Various doc fixes

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.22.0

Features

  • Add label to serial nodes [0fcaa08]

This allows serial tests to be filtered using the label-filter

Maintenance

Various doc fixes

Commits

Updates github.com/onsi/gomega from 1.34.2 to 1.36.1

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.36.1

1.36.1

Fixes

v1.36.0

1.36.0

Features

  • new: make collection-related matchers Go 1.23 iterator aware [4c964c6]

Maintenance

  • Replace min/max helpers with built-in min/max [ece6872]
  • Fix some typos in docs [8e924d7]

v1.35.1

1.35.1

Fixes

  • Export EnforceDefaultTimeoutsWhenUsingContexts and DisableDefaultTimeoutsWhenUsingContext [ca36da1]

v1.35.0

1.35.0

Features

  • You can now call EnforceDefaultTimeoutsWhenUsingContexts() to have Eventually honor the default timeout when passed a context. (prior to this you had to expclility add a timeout) [e4c4265]
  • You can call StopTrying(message).Successfully() to abort a Consistently early without failure [eeca931]

Fixes

  • Stop memoizing the result of HaveField to avoid unexpected errors when used with async assertions. [3bdbc4e]

Maintenance

  • Bump all dependencies [a05a416]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.36.1

Fixes

1.36.0

Features

  • new: make collection-related matchers Go 1.23 iterator aware [4c964c6]

Maintenance

  • Replace min/max helpers with built-in min/max [ece6872]
  • Fix some typos in docs [8e924d7]

1.35.1

Fixes

  • Export EnforceDefaultTimeoutsWhenUsingContexts and DisableDefaultTimeoutsWhenUsingContext [ca36da1]

1.35.0

Features

  • You can now call EnforceDefaultTimeoutsWhenUsingContexts() to have Eventually honor the default timeout when passed a context. (prior to this you had to expclility add a timeout) [e4c4265]
  • You can call StopTrying(message).Successfully() to abort a Consistently early without failure [eeca931]

Fixes

  • Stop memoizing the result of HaveField to avoid unexpected errors when used with async assertions. [3bdbc4e]

Maintenance

  • Bump all dependencies [a05a416]
Commits

Updates golang.org/x/text from 0.19.0 to 0.21.0

Commits
  • d42948e go.mod: update golang.org/x dependencies
  • efd25da go.mod: update golang.org/x dependencies
  • 8a0e65e README: don't recommend go get
  • fefda1a internal/texttest: remove Run and Bench helpers
  • a457f47 all: normalize subtest names to NFC
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested a review from a team as a code owner December 10, 2024 05:54
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 10, 2024
anmazzotti
anmazzotti previously approved these changes Dec 10, 2024
View reviewed changes
@salasberryfin salasberryfin added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 12, 2024
@salasberryfin salasberryfin mentioned this pull request Dec 12, 2024
Closed
salasberryfin
salasberryfin previously approved these changes Dec 12, 2024
View reviewed changes
@alexander-demicev alexander-demicev force-pushed the dependabot/go_modules/dependencies-0d77300225 branch from d76b2b6 to 7adf1b4 Compare December 13, 2024 10:15
@alexander-demicev
Copy link
Member

@dependabot rebase

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 13, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@alexander-demicev
Copy link
Member

@dependabot recreate

@dependabot dependabot bot dismissed stale reviews from salasberryfin and anmazzotti via c5b9789 December 13, 2024 10:21
@dependabot dependabot bot force-pushed the dependabot/go_modules/dependencies-0d77300225 branch from 7adf1b4 to c5b9789 Compare December 13, 2024 10:21
@salasberryfin salasberryfin removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 13, 2024
@alexander-demicev alexander-demicev force-pushed the dependabot/go_modules/dependencies-0d77300225 branch from 98a5988 to 66587a8 Compare December 13, 2024 10:27
@salasberryfin salasberryfin added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 13, 2024
@furkatgofurov7
Copy link
Contributor

Run CI checks that is failing here is passing for me locally without any problems

furkatgofurov7
furkatgofurov7 previously approved these changes Dec 13, 2024
View reviewed changes
dependabot bot added 2 commits December 13, 2024 14:40
@dependabot @furkatgofurov7
chore(deps): Bump the dependencies group across 1 directory with 3 up…
137b698 
…dates

Bumps the dependencies group with 3 updates in the / directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo), [github.com/onsi/gomega](https://github.com/onsi/gomega) and [golang.org/x/text](https://github.com/golang/text).


Updates `github.com/onsi/ginkgo/v2` from 2.21.0 to 2.22.0
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.21.0...v2.22.0)

Updates `github.com/onsi/gomega` from 1.34.2 to 1.36.1
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.34.2...v1.36.1)

Updates `golang.org/x/text` from 0.19.0 to 0.21.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.19.0...v0.21.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @furkatgofurov7
Update generated code
05b1d3c 
Signed-off-by: github-actions[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@furkatgofurov7 furkatgofurov7 force-pushed the dependabot/go_modules/dependencies-0d77300225 branch from 66587a8 to 05b1d3c Compare December 13, 2024 12:45
@furkatgofurov7
Copy link
Contributor

Run CI checks that is failing here is passing for me locally without any problems

After rebasing on top of the main, they seem to be passing

@furkatgofurov7
Bump CAPI and AWS providers
1cced21 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 dismissed stale reviews from alexander-demicev and themself via 1cced21 December 13, 2024 13:53
@furkatgofurov7 furkatgofurov7 changed the title chore(deps): Bump the dependencies group across 1 directory with 3 updates Bump CAPI and CAPA Dec 13, 2024
@kkaempf kkaempf added this to the December release milestone Dec 13, 2024
@alexander-demicev
Copy link
Member

alexander-demicev commented Dec 13, 2024 •
edited
Loading

Please verify that e2e nightly suite passes before merging the CAPI bump. You can do this by creating a branch in Turtles repo and choosing it as a base for the workflow.

@furkatgofurov7
Copy link
Contributor

Please verify that e2e nightly suite passes before merging the CAPI bump. You can do this by creating a branch in Turtles repo and choosing it as a base for the workflow.

@alexander-demicev this PR does bump CAPI only for the constant value (maybe changing the title on this PR was not a good idea) used in some e2e and provider sync tests since it expected the version to be set to latest. However, more appropriate CAPI bump PR is on flight here: https://github.com/rancher/turtles/pull/925/files.

I suggest to wait for #925 to be merged first before taking this one in.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 17, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Dec 17, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/dependencies-0d77300225 branch December 17, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@alexander-demicev alexander-demicev alexander-demicev left review comments

@yiannistri yiannistri yiannistri left review comments

@anmazzotti anmazzotti anmazzotti left review comments

@salasberryfin salasberryfin salasberryfin left review comments

Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Archived in project
Milestone
December release
Development

Successfully merging this pull request may close these issues.
6 participants
@alexander-demicev @furkatgofurov7 @yiannistri @salasberryfin @anmazzotti @kkaempf