Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix local tilt setup #948

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Dec 26, 2024

What this PR does / why we need it:
etcd-restore image is already built as part of the turtles Dockerfile located in the root of repo and binary called as manager. As is it fails to find the ./etcd-snapshot-restore command:

turtles-etcd… │ [event: pod rancher-turtles-system/rancher-turtles-etcdsnapshotrestore-controller-manager-5858znqr] Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "./etcd-snapshot-restore": stat ./etcd-snapshot-restore: no such file or directory: unknown

So, this patch renames the command to use the correct binary name, removes redundant commands and original Dockerfile from the exp/etcdrestore folder.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
image

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner December 26, 2024 15:40
@salasberryfin salasberryfin merged commit 9a0de64 into rancher:main Dec 27, 2024
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the fix-tillt branch December 27, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants