Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Add cluster upgrade strategy to rke #1069

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Add cluster upgrade strategy to rke #1069

merged 2 commits into from
Jan 28, 2020

Conversation

mrajashree
Copy link
Contributor

@mrajashree mrajashree commented Jan 17, 2020 •
edited
Loading

@mrajashree mrajashree force-pushed the nodeUpgradeStrategy branch 3 times, most recently from 919747e to 3a7b40c Compare January 17, 2020 19:45
@superseb superseb self-requested a review January 17, 2020 23:22
@mrajashree mrajashree mentioned this pull request Jan 20, 2020
Merged
9 tasks
@mrajashree mrajashree force-pushed the nodeUpgradeStrategy branch 2 times, most recently from 01514d6 to 4db618b Compare January 21, 2020 14:59
@mrajashree mrajashree requested a review from a team January 21, 2020 17:20
@kinarashah kinarashah mentioned this pull request Jan 21, 2020
Closed
kinarashah
kinarashah previously approved these changes Jan 24, 2020
View reviewed changes
superseb
superseb previously approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@superseb superseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 50% is the accepted default, LGTM

@maggieliu maggieliu requested a review from a team January 27, 2020 17:49
@mrajashree mrajashree dismissed stale reviews from superseb and kinarashah via 8ef23f3 January 27, 2020 18:15
@mrajashree mrajashree force-pushed the nodeUpgradeStrategy branch 3 times, most recently from 8d85c9a to 50071b0 Compare January 27, 2020 22:26
superseb
superseb approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@superseb superseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrajashree
Copy link
Contributor Author

Based on offline discussion, upgrade strategy will have a default of 10% and min 1

@mrajashree mrajashree merged commit 56c60bf into rancher:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cloudnautique cloudnautique cloudnautique left review comments

@superseb superseb superseb approved these changes

@dramich dramich dramich approved these changes

@kinarashah kinarashah Awaiting requested review from kinarashah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrajashree @cloudnautique @superseb @dramich @kinarashah