Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to not admit RoleTemplates with both context=cluster & ProjectCreatorDefault=true #337

Merged
merged 11 commits into from
Apr 2, 2024
Merged

Add validation to not admit RoleTemplates with both context=cluster & ProjectCreatorDefault=true #337

merged 11 commits into from
Apr 2, 2024

Conversation

vatsalparekh
Copy link
Contributor

@vatsalparekh vatsalparekh commented Mar 5, 2024 •
edited
Loading

Issue:

Add validation to not admit RoleTemplates with both context=cluster & ProjectCreatorDefault=true

Problem

SURE-7635

Solution

Add a check for this field in validation

CheckList

  • Test
  • Docs

@vatsalparekh vatsalparekh force-pushed the cluster-context-ProjectCreatorDefault branch from 5a9801f to 9eaa18d Compare March 20, 2024 09:02
@vatsalparekh vatsalparekh marked this pull request as ready for review March 20, 2024 09:06
@vatsalparekh vatsalparekh requested a review from a team as a code owner March 20, 2024 09:06
@samjustus
Copy link

rancher/rancher#44860

@samjustus samjustus requested a review from bigkevmcd March 21, 2024 18:22
bigkevmcd
bigkevmcd reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think the actual fix is fine, I think we can improve the tests to clarify that they're testing.

tests/integration/roleTemplate_test.go Outdated Show resolved Hide resolved
@JonCrowther JonCrowther self-requested a review March 25, 2024 20:30
@vatsalparekh vatsalparekh requested a review from bigkevmcd March 27, 2024 09:18
@vatsalparekh
Add validation to not admit RoleTemplates with both context=cluster &…
5493772 
… ProjectCreatorDefault=true

Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Add test for cluster-contexted roleTemplate
6199da8 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Add unit test
2148872 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Update docs for cluster context
89f6597 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Add more info to the test
b3bb903 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Add more descriptive err msg
95e0d48 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Correct validating logic
4055633 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Make test more readable
b2c62c1 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Rollback the change
e8da5e2 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh
Typo fix
9d7db6b 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
@vatsalparekh vatsalparekh force-pushed the cluster-context-ProjectCreatorDefault branch from d9f1686 to 9d7db6b Compare April 1, 2024 12:35
@vatsalparekh
Explicitly add Context
a93553b 
Signed-off-by: Vatsal Parekh <vatsalparekh@outlook.com>
bigkevmcd
bigkevmcd approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@bigkevmcd bigkevmcd merged commit 81fbbb8 into rancher:release/v0.5 Apr 2, 2024
1 check passed
@vatsalparekh vatsalparekh deleted the cluster-context-ProjectCreatorDefault branch April 3, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonCrowther JonCrowther JonCrowther approved these changes

@bigkevmcd bigkevmcd bigkevmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vatsalparekh @samjustus @bigkevmcd @JonCrowther