Fleet RBAC - InheritedFleetWorkspacePermissions validation #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MbolotSuse
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
A couple of items:
- You need escalation checks for GlobalRoleBindings as well as GlobalRoles
- Please update the docs for the GlobalRole checks.
- The escalation logic is a bit flawed. The approach that we use needs to consider these permissions on their own since it gives permissions on all current workspaces and all future workspaces (besides local).
pkg/resources/rbac.authorization.k8s.io/v1/clusterrole/validator_test.go
Show resolved
Hide resolved
pkg/resources/rbac.authorization.k8s.io/v1/clusterrolebinding/validator_test.go
Show resolved
Hide resolved
raulcabello
force-pushed
the
inherited-fleet-roles
branch
3 times, most recently
from
cf97831 to
006c813
Compare
MbolotSuse
suggested changes
Apr 15, 2024
pkg/resources/rbac.authorization.k8s.io/v1/clusterrole/validator.go
Outdated
Show resolved
Hide resolved
pkg/resources/rbac.authorization.k8s.io/v1/clusterrolebinding/validator.go
Outdated
Show resolved
Hide resolved
MbolotSuse
suggested changes
Apr 22, 2024
pkg/auth/globalrole.go
Outdated
| return nil | ||
| } | ||
|
|
||
| var rules []rbacv1.PolicyRule |
There was a problem hiding this comment.
Rather than allocating a new slice and copying the rules over, it might be good to just return what is in the role - like gr.InheritedFleetWorkspacePermissions.ResourceRules
pkg/resolvers/grbClusterResolver.go
Outdated
There was a problem hiding this comment.
The core object here is called a GRBClusterRuleResolver. I don't think that we can make this evaluate other types of rules (i.e. permissions on/in the workspace) without a name change.
There was a problem hiding this comment.
renamed to GRBRuleResolver
pkg/resources/management.cattle.io/v3/globalrolebinding/validator.go
Outdated
Show resolved
Hide resolved
pkg/resources/rbac.authorization.k8s.io/v1/clusterrolebinding/validator_test.go
Outdated
Show resolved
Hide resolved
raulcabello
force-pushed
the
inherited-fleet-roles
branch
from
36016dc to
9f1fb01
Compare
JonCrowther
previously approved these changes
May 2, 2024
JonCrowther
previously approved these changes
May 23, 2024
JonCrowther
reviewed
Jun 14, 2024
JonCrowther
previously approved these changes
Jun 14, 2024
raulcabello
force-pushed
the
inherited-fleet-roles
branch
from
57b1a9f to
1d1092f
Compare
raulcabello
force-pushed
the
inherited-fleet-roles
branch
from
1d1092f to
c7b77c9
Compare
JonCrowther
previously approved these changes
Jun 20, 2024
MbolotSuse
reviewed
Jun 20, 2024
- Validate the user have enough permission to create/update the rules defined in InheritedFleetWorkspacePermissions.ResourceRules - Validate the user have enough permission to create/pdate the rules that are generated based on the InheritedFleetWorkspacePermissions.WorkspaceVerbs
Co-authored-by: Michael Bolot <michael.bolot@suse.com>
raulcabello
force-pushed
the
inherited-fleet-roles
branch
from
c7b77c9 to
70b603a
Compare
JonCrowther
approved these changes
Jun 21, 2024
MbolotSuse
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#44901
Problem
Need to add validation for the new fields in
GlobalRoleInheritedFleetWorkspacePermissionsSolution
InheritedFleetWorkspacePermissions.ResourceRulesInheritedFleetWorkspacePermissions.WorkspaceVerbsauthz.management.cattle.io/gr-ownerandauthz.management.cattle.io/grb-ownerinClusterRoleandClusterRoleBindingCheckList