Remove external-rules feature flag #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcabello
force-pushed
the
remove-external-rules-flag
branch
from
266d402 to
cf2bdaa
Compare
raulcabello
force-pushed
the
remove-external-rules-flag
branch
from
cf2bdaa to
0fbfa43
Compare
raulcabello
requested review from
andreas-kupries,
bigkevmcd,
enrichman and
JonCrowther
pmatseykanets
approved these changes
Jun 25, 2024
andreas-kupries
approved these changes
Jun 25, 2024
| cr, err := r.clusterRoles.Get(roleTemplate.Name) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get ClusterRole %q: %w", roleTemplate.Name, err) | ||
| return nil, fmt.Errorf("for external RoleTemplates, externalRules must be provided or a backing clusterRole must be installed to check for privilege escalations: failed to get ClusterRole %q: %w", roleTemplate.Name, err) |
There was a problem hiding this comment.
Explicitly noting that this looks ok, given that a similar change in the rancher/rancher#45864 (review) got marked as problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#45863
Problem
external-rulesfeature flag was added in Rancher v2.7 and v2.8 to help admins with the transition of the newRoleTemplatefieldExternalRules. That's no longer needed in Rancher v2.9Solution
Remove
external-rulesfeature flag. It will work as it is always enabled, and can't be disabled.