Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #176

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix tests #176

merged 2 commits into from
Nov 29, 2023

Conversation

mddamato
Copy link
Contributor

Fix tests

@mddamato mddamato mentioned this pull request Nov 28, 2023
Merged
4 tasks
adamacosta
adamacosta approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@adamacosta adamacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to have worked. I don't know how the action runner for this is setup, but in the future, maybe consider giving permissions to the EC2 instance profile so we don't need to set all of these or store any secrets.

@adamacosta adamacosta merged commit c819bac into main Nov 29, 2023
5 checks passed
@adamacosta adamacosta deleted the test-tests-mdd0 branch November 29, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamacosta adamacosta adamacosta approved these changes

Assignees

@adamacosta adamacosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mddamato @adamacosta