Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unnecessary code #204

Conversation

aleiner
Copy link
Contributor

@aleiner aleiner commented Apr 12, 2024

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

Removes an unneeded debug message about skipping installation if RKE2 is already installed.- since we support doing upgrades, this is invalid.

Which issue(s) this PR fixes:

Fixes #201

Release Notes

NONE

@aleiner aleiner linked an issue Apr 12, 2024 that may be closed by this pull request
@aleiner aleiner requested a review from mddamato April 12, 2024 17:36
@aleiner aleiner marked this pull request as draft April 12, 2024 18:59
Adam Leiner added 2 commits April 12, 2024 16:31
…1-check-if-rke-server-is-previously-installed-does-nothing-beneficial
@aleiner aleiner marked this pull request as ready for review April 12, 2024 20:42
@mddamato mddamato merged commit c8264a7 into main Apr 15, 2024
5 checks passed
@aleiner aleiner deleted the 201-check-if-rke-server-is-previously-installed-does-nothing-beneficial branch April 15, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if rke-server is previously installed does nothing beneficial
2 participants