Merge pull request #4191 from randombit/jack/pcurves-is-even-ct

Avoid a potentially troublesome construct in pcurves is_even
randombit · Jul 10, 2024 · 69a51e9 · 69a51e9
2 parents d14ca95 + 2866ee3
commit 69a51e9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/lib/math/pcurves/pcurves_impl.h b/src/lib/math/pcurves/pcurves_impl.h
@@ -120,7 +120,7 @@ class IntMod final {
 
       constexpr CT::Choice is_even() const {
          auto v = Rep::from_rep(m_val);
-         return CT::Choice::from_int(0x01 ^ (v[0] & 0x01));
+         return !CT::Choice::from_int(v[0] & 0x01);
       }
 
       friend constexpr Self operator+(const Self& a, const Self& b) {