Chore: BufferTransformer #3942
Closed
Chore: BufferTransformer #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This demotes Block_Cipher::encrypt_n/decrypt_n to top-level methods and introduces new (private) virtual methods (encrypt/decrypt_blocks) that use std::span for the in/out buffers. Also, this adapts all block cipher implementations in the library to use the new API.
reneme
force-pushed
the
chore/buffer_transformer
branch
from
e9d416f
to
00ff565
Compare
Basically so, yeah. I wonder if we can fit in some other common functionality there, namely the word level loads/stores. That's a very common task (encrypt+decrypt for N ciphers plus alternative implementations) so if there is a nice way to make that work it would cut some complexity. Not necessary for the initial PR. I just found an explict slicer+stuffer quite verbose in the original change. |
This was referenced Jun 26, 2024
|
This is superseded by #4151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Dependencies
Description
This is in response of #3885 (comment): Combining the
BufferStufferandBufferSlicerinto aBufferTransformerthat always acts on two buffers (one input, one output) in lock-step. Block ciphers (and in particular implementations ofBlockCipher::encrypt_n()/::decrypt_n()) are a typical use case for this helper.I added this spike on #3870, which introduced
std::spanin the relevant methods, to simplify the integration. See Rohde-Schwarz@00ff565 for the relevant patch.@randombit Is that what you had in mind?