Refactor pcurves affine conversions and inversion usage #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/affine-this-you-filthy-casual
branch
3 times, most recently
from
f8c482e
to
1c74f21
Compare
randombit
force-pushed
the
jack/affine-this-you-filthy-casual
branch
from
1c74f21
to
ea9b922
Compare
We did not consistently take advantage of any optimized addition chain for inversions, particularly in table setup and hash to curve code. Also refactor hash to curve such that we avoid a pointless affine conversion in the NU case; previously we returned a projective point even in that case, then later converted it to affine.
randombit
force-pushed
the
jack/affine-this-you-filthy-casual
branch
from
ea9b922
to
709ffed
Compare
|
@reneme ping |
thillux
pushed a commit
to thillux/botan
that referenced
this pull request
Aug 16, 2024
This was deleted in randombit#4263 then resurrected after a rebase in randombit#4217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not consistently take advantage of any optimized addition chain for inversions, particularly in table setup and hash to curve code.
Also refactor hash to curve such that we avoid a pointless affine conversion in the NU case; previously we returned a projective point even in that case, then later converted it to affine.