Add pcurves P-224 #4218
Merged
Add pcurves P-224 #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
randombit
force-pushed
the
jack/pcurves-p224
branch
2 times, most recently
from
576a768
to
8dad7d6
Compare
randombit
force-pushed
the
jack/pcurves-p224
branch
from
8dad7d6
to
5b80202
Compare
|
Emscripten failure seems to be a Homebrew/Emscripten mess emscripten-core/emscripten#22249 hopefully addressed soon but not related to the change |
randombit
force-pushed
the
jack/pcurves-p224
branch
from
5b80202
to
993a518
Compare
This one is a little more involved since this is the first curve where p != 3 mod 4, and in fact since P-224 is == 1 mod 16 we must use Shanks-Tonelli GH #4027
The speedup we get from Solinas for P-224 (around 25%) is much higher than seen for P-192 or P-256. This may be due to the fact that unlike P-192 and P-256, P-224 is not "Montgomery friendly", ie p' is not equal to 1, so the Montgomery reduction is significantly more expensive.
Improves ECDSA signature by 5%, ECDSA verify by 1%, ECDH agreement by 1% Also add the script to convert the output of addchain into pcurves code
randombit
force-pushed
the
jack/pcurves-p224
branch
from
5589c41
to
0cb7102
Compare
|
@reneme Ping. Wasn't sure if you cared about this one. Main point I'd be interested in more eyes is the Shanks-Tonelli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a little more involved since this is the first curve where p != 3 mod 4, and in fact since P-224 is == 1 mod 16 we must use Shanks-Tonelli
GH #4027