Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUMS curve numsp512d1 #4251

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Add NUMS curve numsp512d1 #4251

merged 2 commits into from
Aug 3, 2024

Conversation

randombit
Copy link
Owner

The NUMS curves are a set of curves generated using a simple and straighforward set of criteria, while also admitting very efficient implementation. Further details can be found in the IETF draft draft-black-numscurves-02

@coveralls
Copy link

coveralls commented Jul 24, 2024

Coverage Status

coverage: 91.725% (+0.1%) from 91.624%
when pulling d7d565b on jack/numsp512d1
into 0d4969a on master.

The NUMS curves are a set of curves generated using a simple and
straighforward set of criteria, while also admitting very efficient
implementation. Further details can be found in the IETF draft
draft-black-numscurves-02
The pcurves addition formula implicitly assumed that if the y coordinates were
identical, then the points were as well. This is not necessarily the case.
@randombit randombit merged commit 2c3fabb into master Aug 3, 2024
39 checks passed
@randombit randombit deleted the jack/numsp512d1 branch August 3, 2024 00:23
@guidovranken
Copy link

@randombit Will you also support nums t1 curves? I have no need for it personally, but SymCrypt by Microsoft supports them (but not nums d1 curves), and they are in fact the only library supported by Cryptofuzz which supports nums natively. Having an oracle for nums t1 curves could benefit the fuzzing of both libraries.

https://github.com/guidovranken/cryptofuzz/blob/8e2f0ee62596cb1dec7e149ccf047a2506049af9/modules/symcrypt/module.cpp#L1170-L1175

@randombit
Copy link
Owner Author

@guidovranken Interesting, I was unaware of this. t1 is a completely different thing (Edwards curve with cofactor 4) so wouldn't happen as part of this ongoing project anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants