change policy tree output format #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randriu
requested changes
Nov 25, 2024
paynt/synthesizer/policy_tree.py
Outdated
| policies_string += "}\n" | ||
|
|
||
| policies_filename = export_filename_base + ".json" | ||
| policies_filename = export_filename_base + ".paynt.json" |
There was a problem hiding this comment.
I would keep the extension of the file simply .json, it does not have to be consistent with .storm.json.
paynt/quotient/mdp_family.py
Outdated
| import json | ||
| json_string = "[\n" | ||
| def policy_to_json(self, state_valuation_to_action): | ||
| """ DT-Control json format """ |
There was a problem hiding this comment.
I prefer to keep the output format as simple as possible, e.g. for use in other projects. Could we maybe add a parameter to this method that determines whether its output is simple or dtControl-specific?
laDok8
force-pushed
the
compare_dt_MAP_vs_Control
branch
from
d49ffcd to
1cd8fd0
Compare
laDok8
force-pushed
the
compare_dt_MAP_vs_Control
branch
from
1cd8fd0 to
df74941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list adheres to DTcontrol format. For POMDP it results in
{ "p0" : [<CONTROLER0>], "p1" : [<CONTROLER1>], ... "pn" : [<CONTROLER2>], }As is structure is not parsable by DT control but each separate controller is