Move away sairedis logrotate from signal handler (sonic-net#1153)

* Move away sairedis logrotate from signal handler * Update tests
raphaelt-nvidia · Feb 4, 2020 · cd68c80 · cd68c80
1 parent 4b1184f
commit cd68c80
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 10 deletions.
diff --git a/orchagent/main.cpp b/orchagent/main.cpp
@@ -47,6 +47,7 @@ int gBatchSize = DEFAULT_BATCH_SIZE;
 bool gSairedisRecord = true;
 bool gSwssRecord = true;
 bool gLogRotate = false;
+bool gSaiRedisLogRotate = false;
 bool gSyncMode = false;
 
 ofstream gRecordOfs;
@@ -73,15 +74,7 @@ void sighup_handler(int signo)
      * Don't do any logging since they are using mutexes.
      */
     gLogRotate = true;
-
-    sai_attribute_t attr;
-    attr.id = SAI_REDIS_SWITCH_ATTR_PERFORM_LOG_ROTATE;
-    attr.value.booldata = true;
-
-    if (sai_switch_api != NULL)
-    {
-        sai_switch_api->set_switch_attribute(gSwitchId, &attr);
-    }
+    gSaiRedisLogRotate = true;
 }
 
 void syncd_apply_view()

diff --git a/orchagent/orchdaemon.cpp b/orchagent/orchdaemon.cpp
@@ -19,6 +19,7 @@ using namespace swss;
 
 extern sai_switch_api_t*           sai_switch_api;
 extern sai_object_id_t             gSwitchId;
+extern bool                        gSaiRedisLogRotate;
 
 extern void syncd_apply_view();
 /*
@@ -400,6 +401,19 @@ void OrchDaemon::flush()
         SWSS_LOG_ERROR("Failed to flush redis pipeline %d", status);
         exit(EXIT_FAILURE);
     }
+
+    // check if logroate is requested
+    if (gSaiRedisLogRotate)
+    {
+        SWSS_LOG_NOTICE("performing log rotate");
+
+        gSaiRedisLogRotate = false;
+
+        attr.id = SAI_REDIS_SWITCH_ATTR_PERFORM_LOG_ROTATE;
+        attr.value.booldata = true;
+
+        sai_switch_api->set_switch_attribute(gSwitchId, &attr);
+    }
 }
 
 void OrchDaemon::start()

diff --git a/tests/mock_tests/mock_orchagent_main.cpp b/tests/mock_tests/mock_orchagent_main.cpp
@@ -18,10 +18,11 @@ int gBatchSize = DEFAULT_BATCH_SIZE;
 bool gSairedisRecord = true;
 bool gSwssRecord = true;
 bool gLogRotate = false;
+bool gSaiRedisLogRotate = false;
 ofstream gRecordOfs;
 string gRecordFile;
 
 MirrorOrch *gMirrorOrch;
 VRFOrch *gVrfOrch;
 
-void syncd_apply_view() {}
+void syncd_apply_view() {}
diff --git a/tests/mock_tests/mock_orchagent_main.h b/tests/mock_tests/mock_orchagent_main.h
@@ -19,6 +19,7 @@ extern int gBatchSize;
 extern bool gSwssRecord;
 extern bool gSairedisRecord;
 extern bool gLogRotate;
+extern bool gSaiRedisLogRotate;
 extern ofstream gRecordOfs;
 extern string gRecordFile;