pica: Switch to dirty flags

raphaelthegreat · Jul 20, 2024 · 964d1b8 · 964d1b8
1 parent 518f723
commit 964d1b8
Show file tree

Hide file tree

Showing 11 changed files with 166 additions and 483 deletions.
diff --git a/src/video_core/debug_utils/debug_utils.cpp b/src/video_core/debug_utils/debug_utils.cpp
@@ -272,11 +272,10 @@ void StartPicaTracing() {
 }
 
 void OnPicaRegWrite(u16 cmd_id, u16 mask, u32 value) {
-    std::lock_guard lock(pica_trace_mutex);
-
     if (!g_is_pica_tracing)
         return;
 
+    std::lock_guard lock(pica_trace_mutex);
     pica_trace->writes.push_back(PicaTrace::Write{cmd_id, mask, value});
 }
 

diff --git a/src/video_core/pica/pica_core.cpp b/src/video_core/pica/pica_core.cpp
@@ -362,6 +362,7 @@ void PicaCore::WriteInternalReg(u32 id, u32 value, u32 mask) {
 
         lighting.luts[lut_config.type][lut_config.index].raw = value;
         lut_config.index.Assign(lut_config.index + 1);
+        rasterizer->MarkLightLutDirty();
         break;
     }
 
@@ -387,7 +388,6 @@ void PicaCore::WriteInternalReg(u32 id, u32 value, u32 mask) {
     case PICA_REG_INDEX(texturing.proctex_lut_data[6]):
     case PICA_REG_INDEX(texturing.proctex_lut_data[7]): {
         auto& index = regs.internal.texturing.proctex_lut_config.index;
-
         switch (regs.internal.texturing.proctex_lut_config.ref_table.Value()) {
         case TexturingRegs::ProcTexLutTable::Noise:
             proctex.noise_table[index % proctex.noise_table.size()].raw = value;
@@ -412,8 +412,8 @@ void PicaCore::WriteInternalReg(u32 id, u32 value, u32 mask) {
         break;
     }
 
-    // Notify the rasterizer an internal register was updated.
-    rasterizer->NotifyPicaRegisterChanged(id);
+    // Mark register as dirty
+    dirty_flags.set(id);
 }
 
 void PicaCore::SubmitImmediate(u32 value) {

diff --git a/src/video_core/pica/pica_core.h b/src/video_core/pica/pica_core.h
@@ -4,6 +4,7 @@
 
 #pragma once
 
+#include <bitset>
 #include "core/hle/service/gsp/gsp_interrupt.h"
 #include "video_core/pica/geometry_pipeline.h"
 #include "video_core/pica/packed_attribute.h"
@@ -240,8 +241,11 @@ class PicaCore {
         }
     };
 
+    using DirtyFlags = std::bitset<RegsInternal::NUM_REGS>;
+
     RegsLcd regs_lcd{};
     Regs regs{};
+    DirtyFlags dirty_flags{};
     // TODO: Move these to a separate shader scheduler class
     GeometryShaderUnit gs_unit;
     ShaderSetup vs_setup;