Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

[WIP] New shape method #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] New shape method #30

wants to merge 1 commit into from

Conversation

raphamorim
Copy link
Owner

@raphamorim raphamorim commented Apr 12, 2016

  • More elegant
  • More More lighter
  • Better to test

New API design:

old way

Reads CSS without read/search by elements

origami('#canvas')
  .load(".className")
  .shape(".className")
  .draw();

new way

NOTE: Now element must exist in DOM.

<div class="className">...</div>
origami('#canvas')
  .shape(".className").draw(); // maybe origami().html() would be better

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.667% when pulling 3dfd385 on feature/new-html2canvas into 2525348 on master.

@raphamorim
Copy link
Owner Author

Ref: #29

@raphamorim raphamorim changed the title new shape method [WIP] New shape method Apr 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants