Avoid security exception capture by specifying target loader.

raphw · Mar 25, 2020 · 6193017 · 6193017
1 parent c4a2cb6
commit 6193017
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/utility/JavaModule.java b/byte-buddy-dep/src/main/java/net/bytebuddy/utility/JavaModule.java
@@ -341,7 +341,7 @@ enum CreationAction implements PrivilegedAction<Dispatcher> {
             @SuppressFBWarnings(value = "REC_CATCH_EXCEPTION", justification = "Exception should not be rethrown but trigger a fallback")
             public Dispatcher run() {
                 try {
-                    Class<?> module = Class.forName("java.lang.Module");
+                    Class<?> module = Class.forName("java.lang.Module", false, null); // e.g. Netbeans contains a comilation target proxy
                     try {
                         Class<?> instrumentation = Class.forName("java.lang.instrument.Instrumentation");
                         return new Dispatcher.Enabled.WithInstrumentationSupport(Class.class.getMethod("getModule"),
@@ -368,8 +368,6 @@ public Dispatcher run() {
                     return Dispatcher.Disabled.INSTANCE;
                 } catch (NoSuchMethodException ignored) {
                     return Dispatcher.Disabled.INSTANCE;
-                } catch (SecurityException ignored) {
-                    return Dispatcher.Disabled.INSTANCE;
                 }
             }
         }