avoid side effects on db interaction argument hash #15042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Apr 13, 2021
jmartin-tech
force-pushed
the
remove-more-side-effects
branch
from
2385aa1 to
dfdbd65
Compare
When passed arguments as `opts` prefer to avoid side-effects from method execution. This extends similar work from rapid7#12740
jmartin-tech
force-pushed
the
remove-more-side-effects
branch
from
dfdbd65 to
5e495d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passed argument hashes as
optsprefer to avoid side-effects from method execution.This extends similar work from #12740
Verification
msfconsoleuse exploit/windows/smb/ms08_067_netapi