Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs v8 debugger eval exploit #8931

Merged
merged 6 commits into from
Sep 25, 2017
Merged

Nodejs v8 debugger eval exploit #8931

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d71f787
initial commit of nodejs debugger eval exploit
coffeetocode Sep 4, 2017
637b83a
add docs for nodejs debugger eval exploit
coffeetocode Sep 7, 2017
97d08e0
fix reviewer comments
coffeetocode Sep 7, 2017
0483168
remove redundant return
coffeetocode Sep 7, 2017
5d009c8
remove dead code
coffeetocode Sep 7, 2017
2966fb7
Accept @shawizard suggestion for formatting msg_body
coffeetocode Sep 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions modules/exploits/multi/misc/nodejs_v8_debugger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ def initialize(info={})
[ 'URL', 'https://github.com/buggerjs/bugger-v8-client/blob/master/PROTOCOL.md' ],
[ 'URL', 'https://github.com/nodejs/node/pull/8106' ]
],
# 'Platform' => ['node'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these aren't necessary, since you already have them in the target, the info command won't show platform if it's not top-level. I found this the other day working on the Struts exploit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'll fix this in the library.

# 'Arch' => [ ARCH_NODEJS ],
'Targets' =>
[
['NodeJS', { 'Platform' => 'nodejs', 'Arch' => 'nodejs' } ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want this to be ARCH_NODEJS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be the answer to the question above. Wasn't clear to me from looking at other modules which was the preferred way of specifying. Let me know if you've got a suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually go by the compatible payloads.

Expand Down