Skip to content

Commit

Permalink
Send the engine-id when calling DiscoveryConnection#save
Browse files Browse the repository at this point in the history
  • Loading branch information
erran committed Mar 24, 2015
1 parent ad936d4 commit e4e21b0
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/nexpose/discovery.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ module Type
# The IP address or fully qualified domain name of the server.
attr_accessor :address

# The engine ID to use for this connection.
attr_accessor :engine_id

# A user name that can be used to log into the server.
attr_accessor :user

Expand Down Expand Up @@ -150,6 +153,7 @@ def as_xml
xml.attributes['user-name'] = @user
xml.attributes['password'] = @password
xml.attributes['type'] = @type if @type
xml.attributes['engine-id'] = @engine_id if @engine_id && @engine_id != -1
xml
end

Expand Down

2 comments on commit e4e21b0

@ugohil-r7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it posible to stop using xml and migrate to new 2.0 api.?

@erran-r7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ugohil-r7 Probably, this change is just meant to unblock @rtaylor-r7 since this was patched in the internal extensions gem and not in the public gem yet, which caused a collision on his side. We should consider doing that work on the site-api branch.

Please sign in to comment.