Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Remove asset from site" method for global assets (asset linking enabled) #228

Closed
gschneider-r7 opened this issue May 10, 2016 · 4 comments · Fixed by #258
Closed

Add "Remove asset from site" method for global assets (asset linking enabled) #228

gschneider-r7 opened this issue May 10, 2016 · 4 comments · Fixed by #258
Labels
Feature
Milestone
5.2.0

Comments

@gschneider-r7
Copy link
Contributor

With asset linking enabled, the same asset can be present in multiple sites. In the UI an asset can be removed from a specific site without deleting the asset altogether. This functionality does not exist in the gem today.

The method docs do need to indicate that removing an asset from the only site it belongs to will delete the asset altogether.

This was brought up on the community site: https://community.rapid7.com/thread/8624
@gschneider-r7 gschneider-r7 modified the milestone: 5.2.0 Sep 8, 2016
@Stiss
Copy link

Stiss commented Jan 24, 2017

Hi,

I've found that I a great need for this. Is it on the road map?

Br
Stiss

gschneider-r7 added a commit that referenced this issue Jan 25, 2017
@gschneider-r7
Add remove_assets_from_site method
2f46c5a 
Use the UI endpoint for removing the site association from a collection
of assets. Note that this can result in assets being deleted if they
either only belong to 1 site or if asset linking is disabled.

Resolves #228
@gschneider-r7 gschneider-r7 mentioned this issue Jan 25, 2017
Merged
3 tasks
@gschneider-r7
Copy link
Contributor Author

Hi @Stiss I've opened a PR #258 to address this. Will see about getting it merged and releasing a new version of the gem soon. I think we have to review what's on master currently as we haven't released in a while and there were some other merges we reverted and such.

@Stiss
Copy link

Stiss commented Jan 26, 2017

Ok, thanks for the info! This feature would help us a lot.

@gschneider-r7
Copy link
Contributor Author

Hi @Stiss this is now available in version 5.2.0 of the Nexpose gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Add remove_assets_from_site method rapid7/nexpose-client
2 participants
@Stiss @gschneider-r7