Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role constructor does not set id = -1 by default #57

Closed
gschneider-r7 opened this issue Apr 4, 2014 · 1 comment · Fixed by #60
Closed

Role constructor does not set id = -1 by default #57

gschneider-r7 opened this issue Apr 4, 2014 · 1 comment · Fixed by #60
Assignees
@gschneider-r7

Comments

@gschneider-r7
Copy link
Contributor

This is inconsistent with many other constructors in the gem.
This was referenced Apr 29, 2014
Closed
Merged
mdaines-r7 added a commit that referenced this issue Apr 29, 2014
@mdaines-r7
Merge pull request #60 from erran/patch-2
4aa434b 
Set role.id to -1 by default on initialization. Also #57
@erran
Copy link
Contributor

erran commented Apr 29, 2014

@gschneider-r7 My changes in #60 sets it on Role's constructor now. I left RoleSummary alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gschneider-r7 gschneider-r7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set role.id to -1 by default on initialization
Set role.id to -1 by default on initialization
2 participants
@erran @gschneider-r7