Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to_map to to_h #94

Closed
mdaines-r7 opened this issue Dec 8, 2014 · 1 comment
Closed

Convert to_map to to_h #94

mdaines-r7 opened this issue Dec 8, 2014 · 1 comment

Comments

@mdaines-r7
Copy link
Contributor

Several objects in filter.rb have to_map methods. It is Ruby standard to use to_h to indicate a method which converts an object to a hash map representation. We should convert these over.

If we don't create a backwards-compatible alias to still respond to to_map, please provide a solid explanation why.
mdaines-r7 added a commit that referenced this issue Dec 30, 2014
@mdaines-r7
Convert to_map to to_hash, #94.
d4a6b48
@mdaines-r7
Copy link
Contributor Author

Converted and aliased.

mdaines-r7 added a commit that referenced this issue Jan 2, 2015
@mdaines-r7
Extend #94 changes to tag criteria.
942401e 
Missed during the refactor to address the to_map method.

Converting to using to_h over to_hash, the logic being that the
method is a pure hash implementation, and not a custom serialization
Hash.

Adds additional method and module documentation that was missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdaines-r7