You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several objects in filter.rb have to_map methods. It is Ruby standard to use to_h to indicate a method which converts an object to a hash map representation. We should convert these over.
If we don't create a backwards-compatible alias to still respond to to_map, please provide a solid explanation why.
The text was updated successfully, but these errors were encountered:
Missed during the refactor to address the to_map method.
Converting to using to_h over to_hash, the logic being that the
method is a pure hash implementation, and not a custom serialization
Hash.
Adds additional method and module documentation that was missing.
Several objects in
filter.rb
haveto_map
methods. It is Ruby standard to useto_h
to indicate a method which converts an object to a hash map representation. We should convert these over.If we don't create a backwards-compatible alias to still respond to
to_map
, please provide a solid explanation why.The text was updated successfully, but these errors were encountered: