Update gem to support XML API adding of schedules to adhoc scans #142
Conversation
Fix some issues with site loading NEX-40391
Fix param name for adhocschedule class NEX-40391
Fix scan_device(s)_with schedule to work properly as I'd moved a line of code I shouldn't have NEX-40391
Fix some issues with site loading NEX-40391
Fix param name for adhocschedule class NEX-40391
Fix scan_device(s)_with schedule to work properly as I'd moved a line of code I shouldn't have NEX-40391
Remove some unnecessary changes to site.rb NEX-40391
…te-api-adhoc-schedule
Remove some unnecessary changes to site.rb NEX-40391
Force parameter added to allow scheduling of adhoc scans in blackout periods. NEX-40391
Fix some issues with site loading NEX-40391
Fix param name for adhocschedule class NEX-40391
Fix scan_device(s)_with schedule to work properly as I'd moved a line of code I shouldn't have NEX-40391
Remove some unnecessary changes to site.rb NEX-40391
Force parameter added to allow scheduling of adhoc scans in blackout periods. NEX-40391
…te-api-adhoc-schedule
| # @param [Array[adhoc_schedules]] list of scheduled times at which to run | ||
| # @return [Status] whether the request was successful | ||
| # | ||
| def scan_devices_with_schedule(devices, schedules) |
There was a problem hiding this comment.
Assignment Branch Condition size for scan_devices_with_schedule is too high. [16.49/15]
| elem = REXML::Element.new('Devices') | ||
| devices.each do |device| | ||
| elem.add_element('device', { 'id' => "#{device.id}" }) | ||
| elem.add_element('device', {'id' => "#{device.id}"}) |
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
Space inside { missing.
Space inside } missing.
| # @param [Array[adhoc_schedules]] list of scheduled times at which to run | ||
| # @return [Status] whether the request was successful | ||
| # | ||
| def scan_devices_with_schedule(devices, schedules) |
There was a problem hiding this comment.
Assignment Branch Condition size for scan_devices_with_schedule is too high. [15.52/15]
|
It might be worth squashing commits on this branch since there are so many with the same comment, but not a big deal. |
| @@ -107,7 +142,7 @@ class Schedule < APIObject | |||
| # The date after which the schedule is disabled, in ISO 8601 format. | |||
| attr_accessor :not_valid_after | |||
|
|
|||
| #TODO Remove this unused attribute | |||
| # TODO: Remove this unused attribute | |||
There was a problem hiding this comment.
When is this supposed to be removed? What depends on it currently?
There was a problem hiding this comment.
The XML API supports this optional field. The backend code reads it but it doesn't do anything special.
|
Are we ok to merge this in please? This functionality is going with nightcrawler |
Update gem to support XML API adding of schedules to adhoc scans
Adding support in to the gem for new feature allowing users to add schedules to adhoc scans.
NEX-40391